Re: make check-world output - Mailing list pgsql-hackers

From Noah Misch
Subject Re: make check-world output
Date
Msg-id 20170403235416.GA2650626@tornado.leadboat.com
Whole thread Raw
In response to Re: make check-world output  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On Mon, Apr 03, 2017 at 03:03:44PM +0900, Michael Paquier wrote:
> On Sat, Apr 1, 2017 at 4:28 PM, Noah Misch <noah@leadboat.com> wrote:
> > The pg_upgrade test suite originated in an age when "make check-world" was
> > forbidden to depend on Perl; the choice was a shell script or a C program.  We
> > do maintain vcregress.pl:upgradecheck(), a Windows-specific Perl port of the
> > suite.  Maintaining both versions has been tedious.  I'd welcome a
> > high-quality rewrite using src/test/perl facilities.
> 
> I need to check in my archives, but I recall having a WIP patch doing that:
> - remove the shell scripts in src/bin/pg_upgrade.
> - remove upgradecheck in vcregress.pl.
> - add a TAP test in src/bin/pg_upgrade to run the upgrade tests.
> So you are interested by that?

No, not really.  A WIP patch is the easy part.  The bulk of the work is giving
it all the coverage, debuggability, and robustness of the current harness.



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Making clausesel.c Smarter
Next
From: Michael Paquier
Date:
Subject: Re: PATCH: Batch/pipelining support for libpq