Postgres Pro
Downloads
Home   >   mailing lists

Re: Re: Declarative partitioning optimization for largeamount of partitions - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: Re: Declarative partitioning optimization for largeamount of partitions
Date
Msg-id 20170324161204.GD16830@e733.localdomain
Whole thread Raw
In response to [HACKERS] Declarative partitioning optimization for large amount of partitions  (Aleksander Alekseev <a.alekseev@postgrespro.ru>)
List pgsql-hackers
Tree view 
Hi Teodor,

Thanks a lot for a review!

> > step1 In pgstat_report_stat() you remove one by one entries from hash and
> > remove them all. Isn't it better to hash_destroy/hash_create or even let hash
> > lives in separate memory context and just resets it?

Agree, fixed.

> > step1 Again, pgstat_report_stat(), all-zero entries aren't deleted from hash
> > although they will be free from point of view of pgStatTabList.

Good point! Fixed.

--
Best regards,
Aleksander Alekseev
Attachment

pgsql-hackers by date:

Previous
From: Amit Khandekar
Date:
Subject: Re: Parallel Append implementation
Next
From: Robert Haas
Date:
Subject: Re: [COMMITTERS] pgsql: Avoid SnapshotResetXmin() during AtEOXact_Snapshot()