Re: [HACKERS] [PATCH] Suppress Clang 3.9 warnings - Mailing list pgsql-hackers

From Noah Misch
Subject Re: [HACKERS] [PATCH] Suppress Clang 3.9 warnings
Date
Msg-id 20170316065520.GA1976012@tornado.leadboat.com
Whole thread Raw
In response to Re: [HACKERS] [PATCH] Suppress Clang 3.9 warnings  (Aleksander Alekseev <a.alekseev@postgrespro.ru>)
Responses Re: [HACKERS] [PATCH] Suppress Clang 3.9 warnings
List pgsql-hackers
This mailing list does not welcome top-post replies.

On Wed, Mar 15, 2017 at 12:04:11PM +0300, Aleksander Alekseev wrote:
> > This is wrong on platforms that do have strlcpy() in libc.
> 
> If it no too much trouble could you please explain what will happen
> on such platforms?

Both port.h and a system header will furnish a strlcpy() declaration.  The #if
you modified exists to avoid that, and your change would make it ineffective
for Clang.  This will have no symptoms, or it will elicit a warning.

> On what platform did you check it?

None.



pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: [HACKERS] Re: new set of psql patches for loading (saving) data from (to) text,binary files
Next
From: Ashutosh Sharma
Date:
Subject: Re: [HACKERS] Microvacuum support for Hash Index