Re: [HACKERS][REVIEW] macaddr 64 bit (EUI-64) datatype support - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: [HACKERS][REVIEW] macaddr 64 bit (EUI-64) datatype support
Date
Msg-id 20170316011919.GF9812@tamriel.snowman.net
Whole thread Raw
In response to Re: [HACKERS][REVIEW] macaddr 64 bit (EUI-64) datatype support  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres,

* Andres Freund (andres@anarazel.de) wrote:
> I see a new warning due to, presumably, this:
> /home/andres/src/postgresql/src/backend/utils/adt/mac8.c: In function ‘hex2_to_uchar’:
> /home/andres/src/postgresql/src/backend/utils/adt/mac8.c:71:23: warning: comparison is always false due to limited
rangeof data type [-Wtype-limits] 
>   if (*ptr < 0 || *ptr > 127)
>                        ^

Ah, yeah, I suppose I can drop that half of the check.

Will push a fix soon.

Thanks!

Stephen

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [HACKERS][REVIEW] macaddr 64 bit (EUI-64) datatype support
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Speedup twophase transactions