Re: [HACKERS] Patch to improve performance of replay ofAccessExclusiveLock - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [HACKERS] Patch to improve performance of replay ofAccessExclusiveLock
Date
Msg-id 20170307170412.p5otd6fhpsph6jcc@alap3.anarazel.de
Whole thread Raw
In response to Re: [HACKERS] Patch to improve performance of replay of AccessExclusiveLock  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-hackers
Hi,

On 2017-03-08 00:15:05 +1300, David Rowley wrote:
> -static List *RecoveryLockList;
> +/*
> + * RecoveryLockTable is a poor man's hash table that allows us to partition
> + * the stored locks. Which partition a lock is stored in is determined by the
> + * xid which the lock belongs to. The hash function is very simplistic and
> + * merely performs a binary AND against the final 0-based partition number.
> + * Splitting into partitions in this way avoids having to look through all
> + * locks to find one specific to a given xid.
> + */
> +static List **RecoveryLockTable;

Why are we open coding this? That strikes me as a bad plan...

Regards,

Andres



pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: [HACKERS] Proposal : Parallel Merge Join
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] Partitioned tables and relfilenode