Re: [HACKERS] amcheck (B-Tree integrity checking tool) - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [HACKERS] amcheck (B-Tree integrity checking tool)
Date
Msg-id 20170209195315.asb7acfogx7w7cqe@alap3.anarazel.de
Whole thread Raw
In response to Re: [HACKERS] amcheck (B-Tree integrity checking tool)  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 2017-02-09 14:48:18 -0500, Robert Haas wrote:
> On Thu, Feb 9, 2017 at 3:05 AM, Andres Freund <andres@anarazel.de> wrote:
> >> +#define CHECK_SUPERUSER() { \
> >> +             if (!superuser()) \
> >> +                     ereport(ERROR, \
> >> +                                     (errcode(ERRCODE_INSUFFICIENT_PRIVILEGE), \
> >> +                                      (errmsg("must be superuser to use verification functions")))); }
> >
> > Please make this either a function or just copy - the macro doesn't buy
> > us anything except weirder looking syntax.
>
> Better yet, remove the check altogether and just revoke access from
> public.  Then the default policy is superuser-only, but the DBA can
> grant access to who they wish.

That works for me as well.



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] amcheck (B-Tree integrity checking tool)
Next
From: Robert Haas
Date:
Subject: Re: \if, \elseif, \else, \endif (was Re: [HACKERS] PSQL commands:\quit_if, \quit_unless)