Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Allow interrupts on waiting standby - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [HACKERS] Allow interrupts on waiting standby
Date
Msg-id 20170126192059.jage7owz7lr6csah@alap3.anarazel.de
Whole thread Raw
In response to Re: [HACKERS] Allow interrupts on waiting standby  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [HACKERS] Allow interrupts on waiting standby  (Simon Riggs <simon@2ndquadrant.com>)
List pgsql-hackers
Tree view 
On 2017-01-26 12:24:44 -0500, Robert Haas wrote:
> On Thu, Jan 26, 2017 at 7:18 AM, Simon Riggs <simon@2ndquadrant.com> wrote:
> > Currently a waiting standby doesn't allow interrupts.
> >
> > Patch implements that.
> >
> > Barring objection, patching today with backpatches.
> 
> "today" is a little quick, but the patch looks fine.  I doubt anyone's
> going to screech too loud about adding a CHECK_FOR_INTERRUPTS() call.

I don't quite get asking for agreement, and then not waiting as
suggested.  I'm personally fine with going with a CHECK_FOR_INTERRUPTS
for now, but I think it'd better to replace it with a latch.

Andres

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [HACKERS] increasing the default WAL segment size
Next
From: "David G. Johnston"
Date:
Subject: Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal