Re: Radix tree for character conversion - Mailing list pgsql-hackers

From Kyotaro HORIGUCHI
Subject Re: Radix tree for character conversion
Date
Msg-id 20161108.110258.59832499.horiguchi.kyotaro@lab.ntt.co.jp
Whole thread Raw
In response to Re: Radix tree for character conversion  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Radix tree for character conversion  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
List pgsql-hackers
Hello,

At Mon, 7 Nov 2016 17:19:29 +0100, Daniel Gustafsson <daniel@yesql.se> wrote in
<39E295B9-7391-40B6-911D-FE852E4604BD@yesql.se>
> > On 07 Nov 2016, at 12:32, Daniel Gustafsson <daniel@yesql.se> wrote:
> > 
> >> On 04 Nov 2016, at 08:34, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> >> 
> >> I'm not sure how the discussion about this goes, these patches
> >> makes me think about coding style of Perl.
> > 
> > Some of this can absolutely be considered style and more or less down to
> > personal preference.  I haven’t seen any coding conventions for Perl so I
> > assume it’s down to consensus among the committers.
> 
> Actually, scratch that; there is of course a perltidy profile in the pgindent
> directory.  I should avoid sending email before coffee..

Hmm.  Somehow perl-mode on my Emacs is stirring with
ununderstandable indentation and I manually correct them so it is
highly probable that the style of this patch is not compatible
with the defined style. Anyway it is better that pgindent
generates smaller patch so I'll try it.

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

pgsql-hackers by date:

Previous
From: Hao Lee
Date:
Subject: Do we need use more meaningful variables to replace 0 in catalog head files?
Next
From: Michael Paquier
Date:
Subject: Re: Do we need use more meaningful variables to replace 0 in catalog head files?