Re: Unused variable in postgres_fdw/deparse.c - Mailing list pgsql-hackers

From Kyotaro HORIGUCHI
Subject Re: Unused variable in postgres_fdw/deparse.c
Date
Msg-id 20161027.090658.213663921.horiguchi.kyotaro@lab.ntt.co.jp
Whole thread Raw
In response to Re: Unused variable in postgres_fdw/deparse.c  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
List pgsql-hackers
Hi,

At Wed, 26 Oct 2016 11:00:17 +0530, Ashutosh Bapat <ashutosh.bapat@enterprisedb.com> wrote in
<CAFjFpRcFoBn0cd1hMueYtkaL+x_KcBD4kJcuvh4jqKtbviCvDw@mail.gmail.com>
> On Wed, Oct 26, 2016 at 6:19 AM, Kyotaro HORIGUCHI
> <horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> Thanks for the patch and sorry for missing this in the review. I
> 
> The patch applies but seems to have a trailing white space.

Oops. My 'git commit' has a hook to warn such mistakes but it is
just made by 'git diff'. Automatic measure made me forget to keep
alert:p

> patch -p1 < /mnt/hgfs/tmp/postgre_fdw_delete_unused_var.patch
> (Stripping trailing CRs from patch.)
> patching file contrib/postgres_fdw/deparse.c
> But that's removed my "patch" command.
> 
> It compiles cleanly and make check in contrib/postgres_fdw does not
> show any failure.

Thanks for confirmation.

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center





pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Speed up Clog Access by increasing CLOG buffers
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: Unused variable in postgres_fdw/deparse.c