Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] A crash and subsequent recovery of themaster can cause the slave to get out-of-sync - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] A crash and subsequent recovery of themaster can cause the slave to get out-of-sync
Date
Msg-id 20161.1183661353@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] A crash and subsequent recovery of themaster can cause the slave to get out-of-sync  ("Florian G. Pflug" <fgp@phlo.org>)
Responses Re: [PATCH] A crash and subsequent recovery of themaster can cause the slave to get out-of-sync
List pgsql-hackers
Tree view 
"Florian G. Pflug" <fgp@phlo.org> writes:
> Tom Lane wrote:
>> Conclusion: we should apply Florian's patch as-is in 8.2, do something
>> morally equivalent in 8.1 and before, and invent a
>> CrashRecoveryCheckpoint record type in HEAD.

> Sounds good.

Actually, now that I look closer, this patch seems completely wrong.
It's predicated on an assumption that rm_cleanup won't write WAL entries
describing what it did ... but, at least in the btree case, it does.
(I think gist/gin might not, but that's a bug in those AMs not in xlog.)
I'm therefore wondering what test case led you to think there was
something wrong.
        regards, tom lane

pgsql-hackers by date:

Previous
From: "Florian G. Pflug"
Date:
Subject: Re: [PATCH] A crash and subsequent recovery of themaster can cause the slave to get out-of-sync
Next
From: Jan Wieck
Date:
Subject: usleep feature for pgbench