Re: typedef FileName not const? - Mailing list pgsql-hackers

From Andres Freund
Subject Re: typedef FileName not const?
Date
Msg-id 20160928001607.3occfnnmsipk4xio@alap3.anarazel.de
Whole thread Raw
In response to typedef FileName not const?  (Mark Dilger <hornschnorter@gmail.com>)
Responses Re: typedef FileName not const?  (Mark Dilger <hornschnorter@gmail.com>)
List pgsql-hackers
Hi,


Can we please keep this topic in one thread? Anybody motivated to apply
these isn't going to have an easy time applying things, and everyone
else is just having a harder time sorting through the mails.

On 2016-09-27 17:08:24 -0700, Mark Dilger wrote:
> along the lines of other similar emails from me of late,
> I tried to avoid casting away const when using the FileName
> typedef.  There are several calls where a (const char *) has to
> be cast to (char *) due to FileName being typedef'd as
> non-const.  But changing the typedef to const doesn't seem to
> conflict with any code in the source tree.

I think the better fix here is to simply remove the typedef. It doesn't
seem to have much of a benefit, and makes using correct types harder as
demonstrated here. We don't even use it internally in fd.c..


Andres



pgsql-hackers by date:

Previous
From: Mark Dilger
Date:
Subject: typedef FileName not const?
Next
From: "Tsunakawa, Takayuki"
Date:
Subject: Re: Supporting huge pages on Windows