Re: pgsql: Address portability issues in bfe16d1a5 test output. - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Address portability issues in bfe16d1a5 test output.
Date
Msg-id 20160913020432.gs7gqrywhz2b3skx@alap3.anarazel.de
Whole thread Raw
In response to Re: pgsql: Address portability issues in bfe16d1a5 test output.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 2016-09-12 21:49:47 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On 2016-09-12 21:33:03 -0400, Tom Lane wrote:
> >> It looks like making your tables temp would work around it ...
>
> > Right. But the more general question about the value of that test
> > remain.  Not that the tables in this test matter given how simple they
> > are, but in general it doesn't hurt to have objects survive the
> > regression tests, to increase dump coverage.
>
> > Shouldn't we just drop that test?
>
> Fair question --- it's not immediately obvious what that tests
> that isn't covered at least as well by the adjacent tests.
> The git history isn't much help: all of that came in in one big
> commit from Tom Lockhart.

Well, then let's drop it (including the definition of user_relns). Doing
so unless somebody protests pdq.

Andres


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Address portability issues in bfe16d1a5 test output.
Next
From: Andres Freund
Date:
Subject: pgsql: Remove user_relns() SRF from regression tests.