Re: mdtruncate leaking fd.c handles? - Mailing list pgsql-hackers

From Andres Freund
Subject Re: mdtruncate leaking fd.c handles?
Date
Msg-id 20160908225042.uzcursaj6ifvoif4@alap3.anarazel.de
Whole thread Raw
In response to Re: mdtruncate leaking fd.c handles?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: mdtruncate leaking fd.c handles?  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On 2016-09-08 18:39:56 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Am I missing something or is md.c:mdtruncate() leaking open files?
> 
> Yeah, I think you're right.
> 
> > This only really matters for VACUUM truncate and ON COMMIT TRUNCATE temp
> > table truncation afaics.
> 
> Also, you'd need a table > 1GB to leak anything at all, which probably
> helps explain why it hasn't been noticed.

Heh, this bug is of some older vintage... Appears to originate in
1a5c450f3024ac57cd6079186c71b3baf39e84eb - before that we did a
FileUnlink(), which includes a FileClose().

Will fix.

Andres



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: mdtruncate leaking fd.c handles?
Next
From: Petr Jelinek
Date:
Subject: Re: Logical Replication WIP