Re: pageinspect: Hash index support - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pageinspect: Hash index support
Date
Msg-id 20160830170633.GA508711@alvherre.pgsql
Whole thread Raw
In response to pageinspect: Hash index support  (Jesper Pedersen <jesper.pedersen@redhat.com>)
Responses Re: pageinspect: Hash index support  (Michael Paquier <michael.paquier@gmail.com>)
Re: pageinspect: Hash index support  (Jeff Janes <jeff.janes@gmail.com>)
List pgsql-hackers
Jesper Pedersen wrote:
> Hi,
> 
> Attached is a patch that adds support for hash indexes in pageinspect.
> 
> The functionality (hash_metap, hash_page_stats and hash_page_items) follows
> the B-tree functions.

I suggest that pageinspect functions are more convenient to use via the
get_raw_page interface, that is, instead of reading the buffer
themselves, the buffer is handed over from elsewhere and they receive it
as bytea.  This enables other use cases such as grabbing a page from one
server and examining it in another one.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: sequences and pg_upgrade
Next
From: Tom Lane
Date:
Subject: Re: Missing checks when malloc returns NULL...