Re: HandleParallelMessages contains CHECK_FOR_INTERRUPTS? - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: HandleParallelMessages contains CHECK_FOR_INTERRUPTS?
Date
Msg-id 20160801202058.GA529842@alvherre.pgsql
Whole thread Raw
In response to HandleParallelMessages contains CHECK_FOR_INTERRUPTS?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: HandleParallelMessages contains CHECK_FOR_INTERRUPTS?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> $SUBJECT seems like a pretty bad idea, because it implies a recursive
> entry to ProcessInterrupts and thence to HandleParallelMessages itself.
> By what reasoning is that call necessary where it's placed?

I notice you just removed the CHECK_FOR_INTERRUPTS in
HandleParallelMessages().  Did you notice that HandleParallelMessages
calls shm_mq_receive(), which calls shm_mq_receive_bytes(), which
contains a CHECK_FOR_INTERRUPTS() call?

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: PostmasterContext survives into parallel workers!?
Next
From: Tom Lane
Date:
Subject: Re: New version numbering practices