Re: Issue with bgworker, SPI and pgstat_report_stat - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Issue with bgworker, SPI and pgstat_report_stat
Date
Msg-id 20160707180656.fu6iojkket5o43nb@alap3.anarazel.de
Whole thread Raw
In response to Re: Issue with bgworker, SPI and pgstat_report_stat  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Issue with bgworker, SPI and pgstat_report_stat  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On 2016-07-07 14:04:36 -0400, Robert Haas wrote:
> On Thu, Jul 7, 2016 at 1:52 PM, Julien Rouhaud
> <julien.rouhaud@dalibo.com> wrote:
> > Should a bgworker modifing data have to call pgstat_report_stat() to
> > avoid this problem? I don't find any documentation suggesting it, and it
> > seems that worker_spi (used as a template for this bgworker and I
> > suppose a lot of other one) is also affected.
> 
> That certainly seems like the simplest fix.  Not sure if there's a better one.

I think a better fix would be to unify the startup & error handling
code. We have way to many slightly diverging copies. But that's a bigger
task, so I'm not protesting against making a more localized fix.

Andres



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Reviewing freeze map code
Next
From: Robert Haas
Date:
Subject: Re: primary_conninfo missing from pg_stat_wal_receiver