On 2016-05-02 16:12:53 -0300, Alvaro Herrera wrote:
> I pushed a fix to some comments, including the ones being discussed in
> this subthread, which should hopefully close things here.
>
> I'm now going to go over Craig's pg_recvlogical changes and the proposed
> for that problem.
- /* oldest LSN that the client has acked receipt for */
+ /*
+ * Oldest LSN that the client has acked receipt for. This is used as the
+ * start_lsn point in case the client doesn't specify one, and also as a
+ * safety measure to back off in case the client specifies a start_lsn
+ * that's further in the future than this value.
+ */ XLogRecPtr confirmed_flush;
This is the wrong way round. confirmed_flush is used if the client's
start_lsn is further in the *past* than this value.
