Re: snapshot too old, configured by time - Mailing list pgsql-hackers

From Andres Freund
Subject Re: snapshot too old, configured by time
Date
Msg-id 20160419150548.ud6u5kdgr7gtaw3a@alap3.anarazel.de
Whole thread Raw
In response to Re: snapshot too old, configured by time  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: snapshot too old, configured by time  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On 2016-04-19 12:03:22 -0300, Alvaro Herrera wrote:
> Kevin Grittner wrote:
> > On Tue, Apr 19, 2016 at 6:38 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> > 
> > > The right thing to do about that is just change it back to the
> > > way Kevin had it originally.
> > 
> > Since this change to BufferGetPage() has caused severe back-patch
> > pain for at least two committers so far, I will revert that (very
> > recent) change to this patch later today unless I hear an
> > objections.
> 
> I vote for back-patching a no-op change instead, as discussed elsewhere.

What about Tom's argument that that'd be problematic for external code?



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: snapshot too old, configured by time
Next
From: Kevin Grittner
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <