Should we remove unused code? - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Should we remove unused code?
Date
Msg-id 20160418180711.55ac82c0@fujitsu
Whole thread Raw
Responses Re: Should we remove unused code?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hello

Today I've read this post:

http://blog.2ndquadrant.com/code-coverage/

I think its great and that everyone in this mailing list should
familiarize themselves with it.

Reading the coverage report, I discovered that some code is never
executed. Sometimes its OK (error reporting in out-of-memory cases),
sometimes its not (not enough tests). But there are also cases I'm not
sure about.

For instance there are two flags - HASH_SEGMENT and HASH_FFACTOR that
are in fact never used (see attachment). I wonder whether we should
keep code like this or not.

What do you think?

--
Best regards,
Aleksander Alekseev
http://eax.me/

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Spinlocks and semaphores in 9.2 and 9.3
Next
From: Andres Freund
Date:
Subject: Re: Spinlocks and semaphores in 9.2 and 9.3