On 2016-04-12 00:32:13 -0400, Tom Lane wrote:
> I wrote:
> > This commit has broken buildfarm member gaur, and no doubt pademelon
> > will be equally unhappy once it catches up to HEAD.
>
> Spoke too soon, actually: pademelon did not get as far as initdb.
>
> cc: "bufmgr.c", line 4032: error 1521: Incorrect initialization.
> cc: "bufmgr.c", line 4058: error 1521: Incorrect initialization.
>
> Apparently, assigning the result of init_spin_delay() is not as portable
> as you thought.
Hm. I'm not sure why not though? Is it because delayStatus isn't static
or global scope?
> Maybe convert that into init_spin_delay(SpinDelayStatus *target,
> whatever-the-other-arg-is) ?
Too bad, my compiler generates a bit nicer code for the current version.
Greetings,
Andres Freund
