Re: Yet another small patch - reorderbuffer.c:1099 - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Yet another small patch - reorderbuffer.c:1099
Date
Msg-id 20160405091235.avds6xcqlzp7yd5l@alap3.anarazel.de
Whole thread Raw
In response to Re: Yet another small patch - reorderbuffer.c:1099  (Aleksander Alekseev <a.alekseev@postgrespro.ru>)
Responses Re: Yet another small patch - reorderbuffer.c:1099  (Simon Riggs <simon@2ndQuadrant.com>)
List pgsql-hackers
On 2016-04-05 12:07:40 +0300, Aleksander Alekseev wrote:
> > I recall discussing this code with Andres, and I think that he has
> > mentioned me this is intentional, because should things be changed for
> > a reason or another in the future, we want to keep in mind that a list
> > of TXIDs and a list of sub-TXIDs should be handled differently.
> 
> I see. If this it true I think there should be a comment that explains
> it. When you read such a code you suspect a bug. Not mentioning that
> static code analyzers (I'm currently experimenting with Clang and PVS
> Studio) complain about code like this.

There's different comments in both branches...



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Support for N synchronous standby servers - take 2
Next
From: Simon Riggs
Date:
Subject: Re: Support for N synchronous standby servers - take 2