Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9. - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.
Date
Msg-id 20160321133358.GB29022@awork2.anarazel.de
Whole thread Raw
In response to Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-committers
Tree view 
On 2016-03-21 09:25:18 -0400, Tom Lane wrote:
> Shouldn't we revert 6f1f34c92b11593e?  AFAICS this patch isn't depending
> on that, but maybe I miss something.

Hm. I'd guess that at least part of it is still required. AddSimpleFrontend()
afaics processes these variables, and I don't think the msvc stuff will
otherwise generate psqlscan.c in the first place.  We probably could
move the knowledge to the explicit AddSimpleFrontend('pgbench')
site. But I'm not personally excited about tinkering with it...

Andres

pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Support parallel aggregation.
Next
From: Robert Haas
Date:
Subject: pgsql: Make max_parallel_degree PGC_USERSET.