Small patch: fix double variable initializations in policy.c - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Small patch: fix double variable initializations in policy.c
Date
Msg-id 20160316112019.64057481@fujitsu
Whole thread Raw
Responses Re: Small patch: fix double variable initializations in policy.c
List pgsql-hackers
Hello

I discovered a pretty weird code.

policy.c:1083

```
char       *qual_value;
ParseState *qual_pstate = make_parsestate(NULL);

/* parsestate is built just to build the range table */
qual_pstate = make_parsestate(NULL);
```

policy.c:1125

```
char       *with_check_value;
ParseState *with_check_pstate = make_parsestate(NULL);

/* parsestate is built just to build the range table */
with_check_pstate = make_parsestate(NULL);
```

I'm quite sure that there is no need to initialize these variables
twice. First patch fixes this. Also I discovered that policy.c is not
properly pgindent'ed. Second patch fixes this too.

Naturally I checked that after applying these patches PostgreSQL still
compiles and pass all regression tests.

--
Best regards,
Aleksander Alekseev
http://eax.me/

Attachment

pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: Choosing parallel_degree
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: multivariate statistics v14