Re: Sanity checking for ./configure options? - Mailing list pgsql-hackers

From David Fetter
Subject Re: Sanity checking for ./configure options?
Date
Msg-id 20160205160852.GA22825@fetter.org
Whole thread Raw
In response to Sanity checking for ./configure options?  (Jim Nasby <Jim.Nasby@BlueTreble.com>)
Responses Re: Sanity checking for ./configure options?
List pgsql-hackers
On Wed, Feb 03, 2016 at 06:02:57PM -0600, Jim Nasby wrote:
> I just discovered that ./configure will happily accept '--with-pgport=' (I
> was actually doing =$PGPORT, and didn't realize $PGPORT was empty). What you
> end up with is a compile error in guc.c, with no idea why it's broken. Any
> reason not to have configure or at least make puke if pgport isn't valid?

That seems like a good idea.

I've been getting rejection to happen with phrases like
   --with-pgport=${PGPORT:?}

which while it looks a little odd, only adds 4 characters to each
shell variable.

Cheers,
David.
-- 
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david.fetter@gmail.com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate



pgsql-hackers by date:

Previous
From: Filip Rembiałkowski
Date:
Subject: proposal: make NOTIFY list de-duplication optional
Next
From: Tomas Vondra
Date:
Subject: Re: silent data loss with ext4 / all current versions