Re: Proposal: Trigonometric functions in degrees - Mailing list pgsql-hackers

From Noah Misch
Subject Re: Proposal: Trigonometric functions in degrees
Date
Msg-id 20160123225506.GB3691823@tornado.leadboat.com
Whole thread Raw
In response to Re: Proposal: Trigonometric functions in degrees  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Proposal: Trigonometric functions in degrees  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sat, Jan 23, 2016 at 05:04:56PM -0500, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > To reliably produce exact answers, this code must delay all trigonometric
> > calculations to runtime.  On sungazer, the float8 test happens to pass if I
> > rebuild float.c with -fno-builtin-sin; that leaves calls like acos(0.5) and
> > cos(60.0 * RADIANS_PER_DEGREE) unprotected, though.
> 
> Either I missed something or there's another issue, because tern/sungazer
> are *still* failing.  This is getting annoying :-(

sungazer's "make check" passes if I change init_degree_constants() to be
non-static.  Duping gcc isn't so easy these days.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Proposal: Trigonometric functions in degrees
Next
From: Tom Lane
Date:
Subject: Re: Patch: ResourceOwner optimization for tables with many partitions