So, Tomas, Teodor, did you like this new version of the patch?
Stas Kelvich wrote:
> > 7) Some of the functions use intexterm that does not match the function
> > name. I see two such cases - to_tsvector and setweight. Is there a
> > reason for that?
>
> Because sgml compiler wants unique indexterm. Both functions that you
> mentioned use overloading of arguments and have non-unique name.
This sounds wrong. I think what you should really do is use
<indexterm> <primary>foo</primary> <secondary>bar</secondary>
</indexterm>
to distinguish the two entries.
It's a bit funny that you reintroduce the "unrecognized weight: %d"
(instead of %c) in tsvector_setweight_by_filter.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
