On 2016-01-11 19:15:23 +0000, Simon Riggs wrote:
> On 11 January 2016 at 19:03, Andres Freund <andres@anarazel.de> wrote:
>
> > Hi,
> >
> > On 2016-01-09 15:29:11 +0000, Simon Riggs wrote:
> > > Hmm, I was just preparing this for commit.
> >
> > Just read downthread that you want to commit this soon. Please hold of
> > for a while, this doesn't really look ready to me. I don't have time for
> > a real review right now, but I'll try to get to it asap.
> >
>
> "A real review"? Huh.
All I meant was that my email didn't consist out of a real review, but
just was a quick scan
> > More generally, I'm doubtful that the approach of reading data from WAL
> > as proposed here is a very good idea. It seems better to "just" dump the
> > entire 2pc state into *one* file at checkpoint time.
> >
>
> I think you misunderstand the proposed approach. This isn't just to do
> with reading things back at checkpoint.
Sure, the main purpose is not to write 2pc state files in the common
path - or is that not the main purpose?
Greetings,
Andres Freund
