Re: 9.5rc1 brin_summarize_new_values - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: 9.5rc1 brin_summarize_new_values
Date
Msg-id 20151227005754.GC58441@alvherre.pgsql
Whole thread Raw
In response to Re: 9.5rc1 brin_summarize_new_values  (Jeff Janes <jeff.janes@gmail.com>)
List pgsql-hackers
Jeff Janes wrote:
> On Sat, Dec 26, 2015 at 8:27 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Michael Paquier <michael.paquier@gmail.com> writes:
> >> On Sat, Dec 26, 2015 at 7:10 AM, Jeff Janes <jeff.janes@gmail.com> wrote:
> >>> brin_summarize_new_values() does not check that it is called on the
> >>> correct type of index, nor does it check permissions.
> >
> >> Yeah, it should have those sanity checks...
> >
> > Yeah, that is absolutely a must-fix.
> 
> Thanks for committing the fix.

Yes, thanks.

> Another issue is:  it seems to have no SGML documentation.  Is that OK?

Hmm, I'm pretty sure I documented it somewhere.  If this can wait till
Monday, I'll have a look by then.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Jeff Janes
Date:
Subject: Re: 9.5rc1 brin_summarize_new_values
Next
From: Joe Conway
Date:
Subject: oldest/newestCommitTs output by pg_controldata