Postgres Pro
Downloads
Home   >   mailing lists

Re: 9.5rc1 brin_summarize_new_values - Mailing list pgsql-hackers

From Jeff Janes
Subject Re: 9.5rc1 brin_summarize_new_values
Date
Msg-id CAMkU=1wMUoUV=CewYd3Xr3HB_BWXCRRUX1Cyce9MNqVXVA5c6Q@mail.gmail.com
Whole thread Raw
In response to Re: 9.5rc1 brin_summarize_new_values  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: 9.5rc1 brin_summarize_new_values  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Re: 9.5rc1 brin_summarize_new_values  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Tree view 
On Sat, Dec 26, 2015 at 8:27 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Michael Paquier <michael.paquier@gmail.com> writes:
>> On Sat, Dec 26, 2015 at 7:10 AM, Jeff Janes <jeff.janes@gmail.com> wrote:
>>> brin_summarize_new_values() does not check that it is called on the
>>> correct type of index, nor does it check permissions.
>
>> Yeah, it should have those sanity checks...
>
> Yeah, that is absolutely a must-fix.

Thanks for committing the fix.

Another issue is:  it seems to have no SGML documentation.  Is that OK?

Cheers,

Jeff

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: Add numeric_trim(numeric)
Next
From: Alvaro Herrera
Date:
Subject: Re: 9.5rc1 brin_summarize_new_values