Re: Re: [BUGS] BUG #13611: test_postmaster_connection failed (Windows, listen_addresses = '0.0.0.0' or '::') - Mailing list pgsql-hackers

From Noah Misch
Subject Re: Re: [BUGS] BUG #13611: test_postmaster_connection failed (Windows, listen_addresses = '0.0.0.0' or '::')
Date
Msg-id 20151108224734.GB1142850@tornado.leadboat.com
Whole thread Raw
In response to Re: Re: [BUGS] BUG #13611: test_postmaster_connection failed (Windows, listen_addresses = '0.0.0.0' or '::')  (Tatsuo Ishii <ishii@postgresql.org>)
List pgsql-hackers
On Thu, Oct 29, 2015 at 05:39:36PM +0900, Tatsuo Ishii wrote:

> > I am happy to finish it, but I am no less happy if you finish it.  Which do
> > you prefer?
> 
> Please go ahead and commit.
> 
> > Should the back-branch commits mirror the master branch?  A more-cautious
> > alternative would be to, in back branches, wrap the change in #ifdefs so it
> > takes effect only on Windows, OpenBSD and NetBSD.  It could break setups with
> > local firewall rules that block connections to "127.0.0.1" or "::1" without
> > blocking "0.0.0.0" or "::".  Such firewall rules sound outlandish enough that
> > I would be fairly comfortable not worrying about this and making the change
> > unconditional in all branches.  It's a judgment call, though.
> 
> I think back patching with #ifdefs is better. On Windows etc. the case
> has been broken anyway and the fix should only bring benefits to users.

I committed it with #ifdef in 9.1-9.4 and without #ifdef in 9.5 and master.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Uh-oh: documentation PDF output no longer builds in HEAD
Next
From: Andres Freund
Date:
Subject: Re: PATCH: 9.5 replication origins fix for logical decoding