Re: creating extension including dependencies - Mailing list pgsql-hackers

From Andres Freund
Subject Re: creating extension including dependencies
Date
Msg-id 20151003151554.GB31874@alap3.anarazel.de
Whole thread Raw
In response to Re: creating extension including dependencies  (Petr Jelinek <petr@2ndquadrant.com>)
Responses Re: creating extension including dependencies  (Andres Freund <andres@anarazel.de>)
Re: creating extension including dependencies  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On 2015-09-20 16:38:58 +0200, Petr Jelinek wrote:
> Here it is.

I went over the patch, trying to commit it. Changed a bunch of stylistic
issues (comments, NOTICE location, ...) . But also found a bug: Namely
cascade_parent was set wrongly in a bunch of situations: When an
extension has multiple dependencies the current name would end up
multiple times on the list, and more importantly a parent's
cascade_parent would be corrupted because the list was being modified
in-place in the child.

Here's an updated patch. Petr, could you please expand the test to
handle a bit more complex cascading setups?

Michael: Why did you exclude test_extensions in Mkvcbuild.pm?

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Idea for improving buildfarm robustness
Next
From: Andres Freund
Date:
Subject: Re: creating extension including dependencies