Re: [COMMITTERS] pgsql: Further fixes for degenerate outer join clauses. - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: [COMMITTERS] pgsql: Further fixes for degenerate outer join clauses.
Date
Msg-id 20150813141005.GY3685@tamriel.snowman.net
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Further fixes for degenerate outer join clauses.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [COMMITTERS] pgsql: Further fixes for degenerate outer join clauses.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> I'm not entirely sure what to do about this.  We could back-patch that
> patch into 9.0 and 9.1, but it's conceivable somebody would squawk about
> planner behavioral changes.  The only other idea that seems practical is
> to remove regression test cases that have platform-specific results in
> those branches.  Probably that wouldn't result in a real reduction in the
> quality of the test coverage for those branches (we could still execute
> the query, just not EXPLAIN it).  But it seems like a pretty ad-hoc
> answer, and the next case might be one that hurts more not to test.
>
> Thoughts?

Have an alternate file for those other cases, rather than remove the
test?  The complaint was about one buildfarm member, so hopefully that's
practical and doesn't require a lot of different permutations.
Thanks!
    Stephen

pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: Test code is worth the space
Next
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Further fixes for degenerate outer join clauses.