Re: Warnings around booleans - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Warnings around booleans
Date
Msg-id 20150812194528.GA21836@awork2.anarazel.de
Whole thread Raw
In response to Warnings around booleans  (Andres Freund <andres@anarazel.de>)
Responses Re: Warnings around booleans  (Michael Meskes <meskes@postgresql.org>)
List pgsql-hackers
Hi Michael,

I'm currently investigating some of our code cleanliness issues around
booleans. Turns out that ecpg fails if C99's _Bool is used as bool
instead of typedef char bool.

Playing around a bit lead to to find that this is caused by a wrong type
declaration in two places. 'isarray' is declared as bool instead of enum
ARRAY_TYPE in two places. This appears to be an oversight, perhaps
caused by the boolean sounding name.

Does this look right to you? If so, will you apply it?

- Andres

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [COMMITTERS] pgsql: Close some holes in BRIN page assignment
Next
From: Peter Eisentraut
Date:
Subject: Re: WIP: SCRAM authentication