Re: track_commit_timestamp and COMMIT PREPARED - Mailing list pgsql-hackers

From Andres Freund
Subject Re: track_commit_timestamp and COMMIT PREPARED
Date
Msg-id 20150804171811.GC32119@awork2.anarazel.de
Whole thread Raw
In response to Re: track_commit_timestamp and COMMIT PREPARED  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: track_commit_timestamp and COMMIT PREPARED
List pgsql-hackers
On 2015-08-04 13:16:52 -0400, Robert Haas wrote:
> On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> > track_commit_timestamp tracks COMMIT PREPARED as expected in standby server,
> > but not in master server. Is this intentional? It should track COMMIT PREPARED
> > even in master? Otherwise, we cannot use commit_timestamp feature to check
> > the replication lag properly while we use 2PC.
> 
> That sounds like it must be a bug.  I think you should add it to the
> open items list.

Yea, completely agreed. It's probably because twophase.c duplicates a
good bit of xact.c. How about we also add a warning to the respective
places that one should always check the others?



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: track_commit_timestamp and COMMIT PREPARED
Next
From: Alvaro Herrera
Date:
Subject: Re: FSM versus GIN pending list bloat