Re: Run pgindent now? - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Run pgindent now?
Date
Msg-id 20150527155359.GA31835@momjian.us
Whole thread Raw
In response to Re: Run pgindent now?  (Andres Freund <andres@anarazel.de>)
Responses Re: Run pgindent now?
List pgsql-hackers
On Wed, May 27, 2015 at 02:31:07AM +0200, Andres Freund wrote:
> But really, the typedef list is the minor part what annoys me about
> pgindent. That it completely butchers so many constructs (e.g. function
> pointer typedefs, inline asm as extreme examples) is much worse. It's
> also neigh on impossible to predict/keep the indentation pgindent will
> use in many cases.  Having to try to write code in a way that doesn't
> break the re-indentation tool, even if it'd otherwise be fine, is just
> absurd.

What does "break" mean here?  Considering we are indenting 1.4M lines of
code, skipping ASM files seems pretty minor.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + Everyone has their own god. +



pgsql-hackers by date:

Previous
From: Christoph Berg
Date:
Subject: pg_upgrade resets timeline to 1
Next
From: Dan Langille
Date:
Subject: PGCon hacker lounge