Re: Run pgindent now? - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Run pgindent now?
Date
Msg-id 20150524021607.GF32396@alap3.anarazel.de
Whole thread Raw
In response to Re: Run pgindent now?  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Run pgindent now?  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On 2015-05-23 21:36:50 -0400, Bruce Momjian wrote:
> pgindent run on HEAD and committed.

-   if (IsA(node, Aggref) || IsA(node, GroupingFunc))
+   if (IsA(node, Aggref) ||IsA(node, GroupingFunc))

There's a bunch of changes like this. Looks rather odd to me? I don't
recall seing much code looking like that?

Also, does somebody have an idea to keep pgindent from butchering inline
asm like:   /*    * Perform cmpxchg and use the zero flag which it implicitly sets when    * equal to measure the
success.   */
 
-   __asm__ __volatile__(
-       "   lock                \n"
-       "   cmpxchgl    %4,%5   \n"
-       "   setz        %2      \n"
-:      "=a" (*expected), "=m"(ptr->value), "=q" (ret)
-:      "a" (*expected), "r" (newval), "m"(ptr->value)
-:      "memory", "cc");
+   __asm__     __volatile__(
+                                  "    lock                \n"
+                                        "  cmpxchgl    %4,%5   \n"
+                                  "   setz     %2      \n"
+                    :           "=a"(*expected), "=m"(ptr->value), "=q"(ret)
+                    :           "a"(*expected), "r"(newval), "m"(ptr->value)
+                            :           "memory", "cc");
+   return (bool) ret;


Andres



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Run pgindent now?
Next
From: Bruce Momjian
Date:
Subject: Re: Run pgindent now?