Re: [PATCH] Generalized JSON output functions - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH] Generalized JSON output functions
Date
Msg-id 20150522144311.GV5885@postgresql.org
Whole thread Raw
In response to Re: [PATCH] Generalized JSON output functions  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: [PATCH] Generalized JSON output functions
List pgsql-hackers
Andrew Dunstan wrote:
> 
> On 05/20/2015 09:16 AM, Shulgin, Oleksandr wrote:

> >Attached is a patch against master to generalize the JSON-producing
> >functions in utils/adt/json.c and to provide a set of callbacks which can
> >be overridden the same way that is already provided for *parsing* JSON.

> I'm not necessarily opposed to this, but it sure seems like a lot of
> changes, and moderately invasive ones, to support something that could be
> done, at the cost of reparsing, with a simple loadable extension that I
> could create in a few hours of programming.

But this seems like a pretty reasonable change to make, no?  Doesn't the
total amount of code decrease after this patch?  JSON stuff is pretty
new so some refactoring and generalization of what we have is to be
expected.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Uriy Zhuravlev
Date:
Subject: Re: WIP: Enhanced ALTER OPERATOR
Next
From: Tom Lane
Date:
Subject: Re: Missing importing option of postgres_fdw