Re: Patch for bug #12845 (GB18030 encoding) - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Patch for bug #12845 (GB18030 encoding)
Date
Msg-id 20150506151325.GX2523@alvh.no-ip.org
Whole thread Raw
In response to Re: Patch for bug #12845 (GB18030 encoding)  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Patch for bug #12845 (GB18030 encoding)
List pgsql-hackers
Robert Haas wrote:
> On Wed, May 6, 2015 at 10:55 AM, Alvaro Herrera
> <alvherre@2ndquadrant.com> wrote:
> > Robert Haas wrote:
> >> On Tue, May 5, 2015 at 9:04 AM, Arjen Nienhuis <a.g.nienhuis@gmail.com> wrote:
> >> > Can someone look at this patch. It should fix bug #12845.
> >> >
> >> > The current tests for conversions are very minimal. I expanded them a
> >> > bit for this bug.
> >> >
> >> > I think the binary search in the .map files should be removed but I
> >> > leave that for another patch.
> >>
> >> Please add this patch to
> >> https://commitfest.postgresql.org/action/commitfest_view/open so we
> >> don't forget about it.
> >
> > If we think this is a bug fix, we should add it to the open items list,
> > https://wiki.postgresql.org/wiki/Open_Items
> 
> It's a behavior change, so I don't think we would consider a back-patch.

Maybe not, but at the very least we should consider getting it fixed in
9.5 rather than waiting a full development cycle.  Same as in
https://www.postgresql.org/message-id/20150428131549.GA25925@momjian.us
I'm not saying we MUST include it in 9.5, but we should at least
consider it.  If we simply stash it in the open CF we guarantee that it
will linger there for a year.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Patch for bug #12845 (GB18030 encoding)
Next
From: Andres Freund
Date:
Subject: Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0