Re: pg_get_constraintdef() doesn't always give an equal constraint - Mailing list pgsql-bugs

From Stephen Frost
Subject Re: pg_get_constraintdef() doesn't always give an equal constraint
Date
Msg-id 20150330150037.GY3663@tamriel.snowman.net
Whole thread Raw
In response to Re: pg_get_constraintdef() doesn't always give an equal constraint  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_get_constraintdef() doesn't always give an equal constraint  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Jon Jensen <jon@endpoint.com> writes:
> > Well, as part of the standard regression test suite it's comparing stor=
ed=20
> > expected output with newly-generated output, like all the other tests. =
I=20
> > must be misunderstanding what you mean because nothing manual about tha=
t,=20
> > is there?
>=20
> My point is that the expected output has to be manually checked initially
> to see if it's right or not; and since it often doesn't look exactly like
> the original SQL, that checking is painful and not foolproof.
>=20
> It's interesting to consider something like the COPY_PARSE_PLAN_TREES
> #define, which inserts code into the backend to see whether copyfuncs.c
> and equalfuncs.c are sane or not.  Running the regression tests with
> that turned on provides pretty thorough coverage of those modules.

Do we have any buildfarm members which are running with that?  If not,
would anyone object to doing so?

    Thanks,

        Stephen

pgsql-bugs by date:

Previous
From: chjischj@163.com
Date:
Subject: BUG #12917: C program created by ecpg core dumped due to “varcharsize * offset”
Next
From: Tom Lane
Date:
Subject: Re: pg_get_constraintdef() doesn't always give an equal constraint