Re: Failure on markhor with CLOBBER_CACHE_ALWAYS for test brin - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Failure on markhor with CLOBBER_CACHE_ALWAYS for test brin
Date
Msg-id 20141231162155.GC1457@alvh.no-ip.org
Whole thread Raw
In response to Re: Failure on markhor with CLOBBER_CACHE_ALWAYS for test brin  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:

> Given that CLOBBER_CACHE_ALWAYS seems to make it fail reliably, the
> obvious explanation is that what's being passed is a pointer into
> catcache or relcache storage that isn't guaranteed to be valid for
> long enough.  The given backtrace doesn't go down far enough to show
> where the bogus input came from, but I'm betting that something is
> returning to SQL a string it got from cache without pstrdup'ing it.

Yep, that was it -- the bug was in getObjectIdentityParts.  I noticed
other three cases of missing pstrdup(), also fixed.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Publish autovacuum informations
Next
From: Andrew Dunstan
Date:
Subject: Re: Initdb-cs_CZ.WIN-1250 buildfarm failures