Re: Using 128-bit integers for sum, avg and statistics aggregates - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Using 128-bit integers for sum, avg and statistics aggregates
Date
Msg-id 20141113023838.GC1791@alvin.alvh.no-ip.org
Whole thread Raw
In response to Re: Using 128-bit integers for sum, avg and statistics aggregates  (Andreas Karlsson <andreas@proxel.se>)
Responses Re: Using 128-bit integers for sum, avg and statistics aggregates  (Andreas Karlsson <andreas@proxel.se>)
List pgsql-hackers
Andreas Karlsson wrote:
> On 11/13/2014 02:03 AM, Andreas Karlsson wrote:
> >Here is version 2 of the patch which detects the presence of gcc/clang
> >style 128-bit integers and has been cleaned up to a reviewable state. I
> >have not added support for any other compilers since I found no
> >documentation 128-bit support with icc or MSVC. I do not have access to
> >any Windows machines either.
> >
> >A couple of things I was not sure about was the naming of the new
> >functions and if I should ifdef the size of the aggregate state in the
> >catalog or not.

configure is a generated file.  If your patch touches it but not
configure.in, there is a problem.

> diff --git a/configure b/configure



-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: On the warpath again about ill-considered inclusion nests
Next
From: Alvaro Herrera
Date:
Subject: Re: pg_multixact not getting truncated