Re: infinite loop in _bt_getstackbuf - Mailing list pgsql-hackers

From Noah Misch
Subject Re: infinite loop in _bt_getstackbuf
Date
Msg-id 20141101003038.GA433704@tornado.leadboat.com
Whole thread Raw
In response to Re: infinite loop in _bt_getstackbuf  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Fri, Oct 31, 2014 at 10:29:53AM -0400, Robert Haas wrote:
> On Thu, Oct 30, 2014 at 11:45 PM, Noah Misch <noah@leadboat.com> wrote:
> >> Given the lack of prior complaints about this
> >> loop, I'm not sure I see the need to work harder than that; corruption
> >> of this sort must be quite rare.
> >
> > Looks like _bt_getstackbuf() is always called with some buffer lock held, so
> > CHECK_FOR_INTERRUPTS() alone would not help:
> >
> > http://www.postgresql.org/message-id/flat/16519.1401395152@sss.pgh.pa.us
> 
> That's the insert path.  What about the vacuum path?

I am not aware of an occasion where the vacuum path will call
_bt_getstackbuf() without already holding some buffer lock.



pgsql-hackers by date:

Previous
From: Jim Nasby
Date:
Subject: Re: pg_background (and more parallelism infrastructure patches)
Next
From: Robert Haas
Date:
Subject: Re: group locking: incomplete patch, just for discussion