On 2014-10-10 16:15:58 +0900, Fujii Masao wrote:
> +1 for applying this change.
I've just done so.
> - (flags & CHECKPOINT_CAUSE_TIME) ? " time" : "");
> + (flags & CHECKPOINT_CAUSE_TIME) ? " time" : "",
> + (flags & CHECKPOINT_FLUSH_ALL) ? " flush-all" :"");
>
> ISTM that you forgot to add the following change.
>
> - msg = "restartpoint starting:%s%s%s%s%s%s%s";
> + msg = "restartpoint starting:%s%s%s%s%s%s%s%s";
> else
> - msg = "checkpoint starting:%s%s%s%s%s%s%s";
> + msg = "checkpoint starting:%s%s%s%s%s%s%s%s";
Good catch. Thanks for having a look! Interesting that gcc can't deduce
this...
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services