Re: pg_background (and more parallelism infrastructure patches) - Mailing list pgsql-hackers

From Andres Freund
Subject Re: pg_background (and more parallelism infrastructure patches)
Date
Msg-id 20141008140943.GC5053@alap3.anarazel.de
Whole thread Raw
In response to Re: pg_background (and more parallelism infrastructure patches)  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: pg_background (and more parallelism infrastructure patches)
List pgsql-hackers
On 2014-09-10 16:53:12 -0400, Robert Haas wrote:
> diff --git a/src/include/libpq/libpq.h b/src/include/libpq/libpq.h
> index 5da9d8d..0b8db42 100644
> --- a/src/include/libpq/libpq.h
> +++ b/src/include/libpq/libpq.h
> @@ -37,6 +37,31 @@ typedef struct
>      }            u;
>  } PQArgBlock;
>  
> +typedef struct
> +{
> +    void (*comm_reset)(void);
> +    int    (*flush)(void);
> +    int    (*flush_if_writable)(void);
> +    bool (*is_send_pending)(void);
> +    int    (*putmessage)(char msgtype, const char *s, size_t len);
> +    void (*putmessage_noblock)(char msgtype, const char *s, size_t len);
> +    void (*startcopyout)(void);
> +    void (*endcopyout)(bool errorAbort);
> +} PQsendMethods;
> +
> +PQsendMethods *PqSendMethods;

WRT my complaint in the other subthread, I think PQsendMethods should
just be renamed to PQcommMethods or similar. That'd, in combination with
a /* at some point we might want to add methods for receiving data here
*/ looks like it'd already satisfy my complaint ;)

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pg_background (and more parallelism infrastructure patches)
Next
From: Andrew Dunstan
Date:
Subject: Re: Context lenses to set/get values in json values.