Re: WIP Patch for GROUPING SETS phase 1 - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: WIP Patch for GROUPING SETS phase 1
Date
Msg-id 20140822125427.GX16422@tamriel.snowman.net
Whole thread Raw
In response to Re: WIP Patch for GROUPING SETS phase 1  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
List pgsql-hackers
* Andrew Gierth (andrew@tao11.riddles.org.uk) wrote:
> Having now spent some more time looking, I believe there is a solution
> which makes it unreserved which does not require any significant pain
> in the code.  I'm not entirely convinced that this is the right
> approach in the long term, but it might allow for a more planned
> transition.
>
> The absolute minimum seems to be:
>
>  GROUPING as a col_name_keyword (since GROUPING(x,y,...) in the select
>  list as a <grouping operation> looks like a function call for any
>  argument types)
>
>  CUBE, ROLLUP, SETS as unreserved_keyword

This means

GROUP BY cube(x,y)
GROUP BY (cube(x,y))
GROUP BY cube(x)

all end up with different meanings though, right?

I'm not sure that's really a better situation.
Thanks,
    Stephen

pgsql-hackers by date:

Previous
From: Jeevan Chalke
Date:
Subject: Re: add line number as prompt option to psql
Next
From: Noah Misch
Date:
Subject: Re: Proposal to add a QNX 6.5 port to PostgreSQL