Re: tab completion for setting search_path - Mailing list pgsql-hackers

From Christoph Berg
Subject Re: tab completion for setting search_path
Date
Msg-id 20140714192018.GE14198@msg.df7cb.de
Whole thread Raw
In response to Re: tab completion for setting search_path  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
Re: Andres Freund 2014-07-12 <20140712135128.GD3494@awork2.anarazel.de>
> I'm also not really happy with the fact that we only complete a single
> search_path item. But it's not easy to do better and when looking around
> other places (e.g. DROP TABLE) don't support it either.

The difference is that the other places don't really need it, i.e. you
can just issue two DROP TABLE. (And I wasn't even aware that DROP
TABLE a, b; exists specifically).

That said, it's great to have the feature, though I'd say making
search_path list-aware should be much higher on the todo list than a
generic solution for other cases.

> I've thought about adding "$user" to the set of completed things as

If we only support one item atm, $user isn't very relevant anyway.

> Fujii wondered about it, but it turns out completions containing $ don't
> work really great because $ is part of WORD_BREAKS.
> E.g. check out what happens if you do
> CREATE TABLE "foo$01"();
> CREATE TABLE "foo$02"();
> DROP TABLE "foo$<tab>
> which means that a single schema that requires quoting will break
> completion of "$user".

Schemas requiring quoting should be rare, so that wouldn't be a big
problem. (Or at least it could solve the problem for most users.)

Christoph
-- 
cb@df7cb.de | http://www.df7cb.de/



pgsql-hackers by date:

Previous
From: Christoph Berg
Date:
Subject: Re: Securing "make check" (CVE-2014-0067)
Next
From: Andres Freund
Date:
Subject: Re: Pg_upgrade and toast tables bug discovered