Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_control is missing a field for LOBLKSIZE - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: pg_control is missing a field for LOBLKSIZE
Date
Msg-id 20140617171255.GF3666@momjian.us
Whole thread Raw
In response to Re: pg_control is missing a field for LOBLKSIZE  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_control is missing a field for LOBLKSIZE  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Tree view 
On Tue, Jun 17, 2014 at 12:28:46PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Uh, I think pg_upgrade needs to check that they match too.
> 
> Possibly.  What do you think it should do when examining a pg_control
> version that lacks the field?

Good question.  I have existing cases where fields were removed, but not
ones that were added.  As we have no way to query the old cluster's
value for LOBLKSIZE, I think I will just add code to compare them if
they _both_ exist.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + Everyone has their own god. +

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD
Next
From: Robert Haas
Date:
Subject: Re: Atomics hardware support table & supported architectures