Re: pgsql: Revive line type - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Revive line type
Date
Msg-id 20140505155835.GD27783@awork2.anarazel.de
Whole thread Raw
In response to pgsql: Revive line type  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: pgsql: Revive line type  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Hi Peter,

On 2013-10-10 02:43:20 +0000, Peter Eisentraut wrote:
> Revive line type
>
> Change the input/output format to {A,B,C}, to match the internal
> representation.
>
> Complete the implementations of line_in, line_out, line_recv, line_send.
> Remove comments and error messages about the line type not being
> implemented.  Add regression tests for existing line operators and
> functions.
>
> Reviewed-by: rui hua <365507506hua@gmail.com>
> Reviewed-by: Álvaro Herrera <alvherre@2ndquadrant.com>
> Reviewed-by: Jeevan Chalke <jeevan.chalke@enterprisedb.com>

That commit missed to update pg_type.h to the changed length of the line
type. Patch attached.

That oversight leads to accesses beyond the length of the tuple in
routines like datumCopy().

Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix case of pg_dump -Fc to an unseekable file (such as a pipe).
Next
From: Bruce Momjian
Date:
Subject: pgsql: Add SGML markup tags to 9.4 release notes