Re: pgsql: Allow opclasses to provide tri-valued GIN consistent functions. - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Allow opclasses to provide tri-valued GIN consistent functions.
Date
Msg-id 20140321212626.GB17111@alap3.anarazel.de
Whole thread Raw
In response to pgsql: Allow opclasses to provide tri-valued GIN consistent functions.  (Heikki Linnakangas <heikki.linnakangas@iki.fi>)
Responses Re: pgsql: Allow opclasses to provide tri-valued GIN consistent functions.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Hi,

On 2014-03-12 15:52:58 +0000, Heikki Linnakangas wrote:
> Allow opclasses to provide tri-valued GIN consistent functions.

clang warns me about a mistake here:
In file included from /home/andres/src/postgresql/src/backend/access/gin/ginxlog.c:16:
In file included from /home/andres/src/postgresql/src/include/access/gin_private.h:14:
/home/andres/src/postgresql/src/include/access/gin.h:57:3: warning: no previous extern declaration for
      non-static variable 'GinLogicValueEnum'
      [-Wmissing-variable-declarations]
} GinLogicValueEnum;

I think the GinLogicValueEnum is supposed to be an enum's name, not a
variable name, right?

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: Remove MinGW readdir/errno bug workaround fixed on 2003-10-10
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Allow opclasses to provide tri-valued GIN consistent functions.