Re: pgsql: Fix crash in json_to_record(). - Mailing list pgsql-committers

From Stephen Frost
Subject Re: pgsql: Fix crash in json_to_record().
Date
Msg-id 20140226192606.GK2921@tamriel.snowman.net
Whole thread Raw
In response to pgsql: Fix crash in json_to_record().  (Jeff Davis <jdavis@postgresql.org>)
List pgsql-committers
* Jeff Davis (jdavis@postgresql.org) wrote:
> Fix crash in json_to_record().
>
> json_to_record() depends on get_call_result_type() for the tuple
> descriptor of the record that should be returned, but in some cases
> that cannot be determined. Add a guard to check if the tuple
> descriptor has been properly resolved, similar to other callers of
> get_call_result_type().
>
> Also add guard for two other callers of get_call_result_type() in
> jsonfuncs.c. Although json_to_record() is the only actual bug, it's a
> good idea to follow convention.

Ah, awesome, thanks.  I had it in my notes to go check that as Coverity
had complained about it and now I don't have to.  Thanks again!

    Stephen

Attachment

pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: btbuild no longer calls _bt_doinsert(), update comment.
Next
From: Andres Freund
Date:
Subject: Re: pgsql: Introduce replication slots.